Closed Bug 1857749 Opened 2 years ago Closed 2 years ago

crashreporter_gtk_common.cpp: duplicate include "crashreporter.h"

Categories

(Toolkit :: Crash Reporting, task)

Product:
Toolkit
Component:
Crash Reporting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: Sylvestre, Assigned: freyalaluna, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Attachments

(1 file, 1 obsolete file)

Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in crashreporter_gtk_common.cpp
48 bytes, text/x-phabricator-request
Details | Review
Attachment #9360135 - Attachment description: WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in → WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in crashreporter+gtk_common.cpp
Attachment #9360135 - Attachment description: WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in crashreporter+gtk_common.cpp → WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in crashreporter_gtk_common.cpp
Attachment #9360135 - Attachment description: WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in crashreporter_gtk_common.cpp → WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in
Assignee: nobody → adel.amodwala
Status: NEW → ASSIGNED

Adel, Freya was working on it. Could you please abandon your patch and try another good first bug?

I can create others like this one

Ah my mistake - I didn't notice that Freya was working on this already.

Consider this patch abandoned. Is there something I need to do to ensure my changes are discarded?

Attachment #9360755 - Attachment is obsolete: true
Attachment #9360135 - Attachment description: WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in → WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in crashreporter_gtk_common.cpp

Hi Sylvestre! I just requested a review for my patch. And apologies for not assigning myself to this bug beforehand. I'm still easing my way into Mozilla's workflow, and I didn't want to overstep and potentially mix something up unexpectedly.

Attachment #9360135 - Attachment description: WIP: Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in crashreporter_gtk_common.cpp → Bug 1857749 - Removed duplicate inclusion of 'crashreporter.h' in crashreporter_gtk_common.cpp
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d13ed541d094 Removed duplicate inclusion of 'crashreporter.h' in crashreporter_gtk_common.cpp r=sylvestre DONTBUILD

https://hg.mozilla.org/mozilla-central/rev/d13ed541d094

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Assignee: adel.amodwala → freya.laluna
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: